English Expression of the Day 17/30 · Stage: Receiving and replying to reviews. All example sentences were created for this article. They are not taken from actual repositories, and the commit hashes are examples.
Table of Contents
- Overview
- 1. Meaning and Nuance
- 2. Examples
- 3. Similar Expressions and Differences
- 4. Common Mistakes Made by Korean Speakers
- 5. One-Line Practice
- Sample Answer
- References
Overview
| Expression | Addressed in a1b2c3d. / I've addressed all the comments. |
| Meaning | Addressed in commit a1b2c3d / I have addressed all the feedback. |
| Context | Inline review replies, PR comments |
| Politeness | Neutral. It is a reporting statement. |
1. Meaning and Nuance
Aside from the noun address, address is frequently used as a verb meaning to deal with or handle a problem or question. Address a comment means to incorporate review feedback, while address a concern means to respond to a worry. While fix means to correct and is suited only for bugs, address covers a wider range of actions, such as answering questions, supplementing documentation, or changing designs.
Addressed in (commit) lets the reviewer know "where the feedback was addressed." GitHub automatically converts commit hashes in comments into links, allowing reviewers to click them and view only the relevant changes. When addressing multiple pieces of feedback, replying to each inline comment this way helps reviewers check them one by one and resolve the conversations.
This is also related to leaving separate commits. The Kubernetes contribution guide advises uploading changes as new commits during a review and not squashing them yet. This is so reviewers can inspect the modifications separately. You squash them when requested toward the end of the review (Part 21). Keep in mind that squashing or rebasing changes the hashes, after which the Addressed in link might point to an old commit.
Habits regarding who resolves conversations vary by repository and reviewer. Reviewers often prefer to check and close them themselves, so when in doubt, the author should just reply and leave closing to the reviewer.
2. Examples
Situation 1: Replying to an inline comment
Addressed in a1b2c3d. I switched to
errors.Is()as you suggested.
Situation 2: Addressing multiple pieces of feedback at once
Thanks for the thorough review! I've addressed all comments in the last two commits:
- renamed
cfgtoconfig- added a nil check before dereferencing
spec.template- documented the new flag in the README
Thorough means meticulous or detailed. It is frequently used to acknowledge the reviewer's effort.
Situation 3: Addressing only some of the feedback
Addressed most of the comments in d4e5f6a. For the caching suggestion, I left a reply below; I'm not sure it's worth the added complexity here.
If not all feedback was addressed, clearly state what remains.
3. Similar Expressions and Differences
- Done. / Fixed. The shortest answers. These are sufficient for minor nitpicks.
- Updated. A broad term meaning "modified." It is natural when changing documentation or explanations.
- Resolved. Means the conversation itself has been settled, the same as GitHub's Resolve conversation button.
4. Common Mistakes Made by Korean Speakers
- I reflected your comment. Translating reflect literally for "incorporate feedback" reads awkwardly as "mirrored in a mirror" or "pondered deeply."
- Corrected sentence: I've addressed your comment. or I've applied your suggestion.
- I modified as you said. The object of modify is missing, and as you said sounds somewhat stiff.
- Corrected sentence: Updated as suggested.
- All fixed. Please merge. Requesting a merge before the reviewer has checked is premature.
- Corrected sentence: I've addressed all the comments. PTAL.
5. One-Line Practice
Rewrite the following Korean sentence as an inline comment reply.
Addressed in commit d4e5f6a. I extracted the timeout into a configuration value as you suggested.
Sample Answer
Addressed in d4e5f6a. I made the timeout configurable as you suggested.
For "extracted into a configuration value," make ... configurable is the most natural. Writing extract to config also conveys the meaning.
Titi's Tip. Just attaching a single commit hash after "Addressed" reduces the number of clicks for the reviewer.
References
- Merriam-Webster, "address" (verb): https://www.merriam-webster.com/dictionary/address
- Kubernetes Contribution Guide, Pull Request Process (Do not squash during review): https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md
- GitHub Docs, Autolinked references and URLs (Commit hash links): https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls